Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance links in video description #66

Closed
yshmarov opened this issue Oct 23, 2023 · 3 comments
Closed

enhance links in video description #66

yshmarov opened this issue Oct 23, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@yshmarov
Copy link
Collaborator

yshmarov commented Oct 23, 2023 •
edited
Loading

  • highlight links
  • add target _blank
  • maybe add referrer?

let me know if you would like to have it and I can try making a PR

Screenshot 2023-10-23 at 23 36 41
@adrienpoly
Copy link
Owner

Yessssssss

@adrienpoly adrienpoly added the good first issue Good for newcomers label Oct 24, 2023
@marcoroth
Copy link
Contributor

marcoroth commented Aug 8, 2024 •
edited
Loading

I think this might be solved now, as links are now being rendered as <a> tags in descriptions.

CleanShot 2024-08-08 at 10 16 08

@adrienpoly
Copy link
Owner

yes probably added the auto link at some point

rubyvideo/app/views/talks/_talk.html.erb

Line 39 in 808947c

<p><%= simple_format auto_link(talk.description, html: {target: "_blank", class: "link"}) %></p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcoroth @adrienpoly @yshmarov