Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the event page #7

Open
adrienpoly opened this issue Jun 17, 2023 · 4 comments · May be fixed by #39
Open

Create the event page #7

adrienpoly opened this issue Jun 17, 2023 · 4 comments · May be fixed by #39
Assignees
Labels
good first issue Good for newcomers

Comments

@adrienpoly
Copy link
Owner

The event page should be a page displaying on la left the event information (date web site location) and on the right the videos from that event.

@adrienpoly adrienpoly added help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed labels Jun 17, 2023
@dedemenezes
Copy link

Hey @adrienpoly, I found your website very interesting and I'm looking forward to start contributing to open-source projects. Do you have a contribution guideline? Also, do you have a layout template for this event page or it is also part of the task?
Thank you in advance

@adrienpoly
Copy link
Owner Author

As a first step I think you can use part of the layout of the speaker page
Event info on the right and the list of talks

CleanShot 2023-06-20 at 15 12 46@2x

As they could be much more talks than on the speaker page you should either have a pagination or an infinite scroll
It would be nice to have the search also scoped for this particular event

Doesn't have to come all at once, just throwing some ideas

@dedemenezes
Copy link

Nice ideas. This layout can be a good starting point and I agree with pagination or infinite scrolling.
I'll work on it later this week. I hope by the weekend I can share some updates in here.
Thank you for assigning me

@dedemenezes dedemenezes linked a pull request Jun 29, 2023 that will close this issue
@dedemenezes
Copy link

Hey @adrienpoly, all good? Did you abandoned this idea to add an event page? Let me know if there is something that I should do different or even redo in case the app has move into a new direction to use still ViewComponents and so on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants