Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out Oaken for seeds and test data #160

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

kaspth
Copy link
Contributor

@kaspth kaspth commented Aug 23, 2024

Paired with @marcoroth

  • Fix db:seed test.

@adrienpoly
Copy link
Owner

thanks @kaspth and @marcoroth for this PR.
Oaken was something I wanted to try out but never really got the time for it. I like how this looks.

While chatting quickly with @marcoroth I understand that the production seed is the issue that remains to be solved.
up to now I was using the seed task to update new content in production. I know it is not really a task that we are due to run in production but so far in our particular case it worked quite well. This being said I wouldn't be opposed to having a dedicated task for ingesting data in prod (and dev for setup) if this could make it easier

PS sorry lots of conflit to solve. They where a large backlog of PR waiting to be merge....

@marcoroth
Copy link
Collaborator

marcoroth commented Sep 2, 2024

I've been wondering if we even should use fixtures/test data in the first place. Would it make sense to just use the actual data in data/ for the tests and write the tests with that in mind?

@kaspth
Copy link
Contributor Author

kaspth commented Oct 11, 2024

heyo, sorry for being out of the loop on this one!

I've been wondering if we even should use fixtures/test data in the first place. Would it make sense to just use the actual data in data/ for the tests and write the tests with that in mind?

@marcoroth this makes sense to me if that's easier.

up to now I was using the seed task to update new content in production. I know it is not really a task that we are due to run in production but so far in our particular case it worked quite well.

@adrienpoly all good, I think having production specific seeds is going to be more common in the future — Oaken is trying to suggest this to people too. I'd just recommend running Rails.application.load_seed directly, which is what the rake db:seed task calls.

@adrienpoly adrienpoly force-pushed the main branch 2 times, most recently from ca98c66 to aa6f659 Compare November 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants