Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic talks filter based on language and kind #384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcoroth
Copy link
Collaborator

CleanShot.2024-11-07.at.20.39.20.mp4

@adrienpoly
Copy link
Owner

I like it very much

One concern is that it introduce a new custom kind of button.
I now from experience that it is very easy to end up with UI having 10s of variation of buttons and color very quickly.
I understand that our set of buttons might not be perfect as they are but I would prefer that we keep consistent sets of buttons across all screens. This will make it easier to improve our overall design down the road

CleanShot 2024-11-08 at 09 59 46@2x

To get something closer to what you had, I made those changes

themes: [
      {
        rubyvideoLight: {
          ...defaultTheme,
          '--btn-text-case': 'none',
          primary: '#DC143C',
          'primary-content': '#ffffff',
          secondary: '#7A4EC2',
          'secondary-content': '#ffffff',
          accent: '#1DA1F2',
          'accent-content': '#ffffff',
          neutral: '#261B23',
          'neutral-content': '#ffffff',
          'base-100': '#F8F9FA',
+          '--rounded-btn': '999px'
          // 'base-content': '#2F2F2F'
          // 'base-100': '#ffffff',
          // info: '#3abff8',
          // success: '#36d399',
          // warning: '#fbbd23',
          // error: '#f87272'
        }
      }
<% classes = "btn btn-sm btn-outline" %>
<% active_classes = "btn-primary btn-active" %>

then in a subsequent PR we could explore what should be our default button for tool bars, outlined with a gray border like you proposed looked great

@adrienpoly adrienpoly force-pushed the main branch 2 times, most recently from ca98c66 to aa6f659 Compare November 10, 2024 15:03
@adrienpoly
Copy link
Owner

Given #433, I wonder if we should introduce some js filters vs having more global talks filters solution.
We could imagine to have in the events#show page a turbo frame with src=/talks?event=event-slug. This would somehow enable filtering/sorting in all talks grid views (speakers, topics, events)

@marcoroth
Copy link
Collaborator Author

I'll rebase this one as soon as have #468 merged in 👍🏼

@adrienpoly
Copy link
Owner

#468 is merged so you can rebase this one.

I think we can go ahead with it like that now but down the road I think the filters can be a backend functionality.

given #433 and the exploratory work in #440 I will try to see if we could have a way to easily embed in a page a grid of talks with some filtering capability so that filters can be available everywhere (topics, event, speakers) and independent of the pagination.

but once again that can be done after this PR is already a great improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants