Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajouter la commune dans la liste des infos renvoyés #16

Closed
gbertherat opened this issue Dec 4, 2020 · 3 comments
Closed

Ajouter la commune dans la liste des infos renvoyés #16

gbertherat opened this issue Dec 4, 2020 · 3 comments

Comments

@gbertherat
Copy link

Dans le JSON qui est renvoyé par le endpoint /temps-attente/agences, ajouter une entrée pour la commune de l'agence si possible. La commune peut être trouvé dans la partie "localité" de open-data.opt.nc (voir bas de l'image qui suit)

image

Éventuellement ajouter le code postal aussi, si juger nécessaire.

Merci!
@adriens
Copy link
Owner

adriens commented Dec 4, 2020

Excellente idée, je propose même en fait de rajouter les champs suivants:

  • type
  • codeESirius
  • idRefLoc
  • codePostalRefloc
  • codePostal
  • lieuDitOuTribu
  • localiteRefloc
  • localite

@adriens adriens pinned this issue Dec 4, 2020
@adriens adriens mentioned this issue Dec 4, 2020
Open
HakumenNC added a commit to HakumenNC/opt-temps-attente-agences-sdk that referenced this issue Dec 9, 2020
@HakumenNC
feat(agences): Additional infos in Agence entity adriens#16
57416e1
@HakumenNC HakumenNC mentioned this issue Dec 9, 2020
Merged
adriens added a commit that referenced this issue Dec 9, 2020
@adriens
Merge pull request #17 from HakumenNC/master
ff2758c 
Ajout informations d'une agence #16
@HakumenNC
Copy link
Contributor

  • type
  • codeESirius
  • idRefLoc
  • codePostalRefloc
  • codePostal
  • lieuDitOuTribu
  • localiteRefloc
  • localite

✔️

@adriens
Copy link
Owner

adriens commented Dec 10, 2020

👏 Efficace 🚀

@adriens adriens closed this as completed Dec 10, 2020
github-actions bot referenced this issue in opt-nc/opt-temps-attente-agences-sdk Nov 22, 2021
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
5516482 
# 1.0.0 (2021-11-22)

### Bug Fixes

* **agences:** Set the right attribute coordsY ([e6e3502](e6e3502))

### Features

* **agences:** Additional infos in Agence entity [#16](#16) ([57416e1](57416e1))
* **commune:** WIP ([b9871fb](b9871fb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HakumenNC @adriens @gbertherat