Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature creep #26

Open
romanchyla opened this issue Nov 27, 2017 · 0 comments
Open

feature creep #26

romanchyla opened this issue Nov 27, 2017 · 0 comments

Comments

@romanchyla
Copy link
Contributor

master pipeline was designed to update solr; later on metrics db was added - but it's sort of 'artificial' connection and the api reflects this 'growing' unease

the central application object has 'update_storage' and 'delete_by_bibcode' methods; those methods only touch the local storage; there exist separate methods for updaitng solr/metrics

a much cleaner api would probably only expose one 'update/delete' method. internally there would be a set of targets, each conforming to a defined api (solr, metrics db....) which would be modified by the application.

another symptom of malaise is that tasks now have to call three methods in order to update a record; see task_delete_record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant