Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facets with incomplete data #32

Open
spacemansteve opened this issue Dec 18, 2017 · 0 comments
Open

Facets with incomplete data #32

spacemansteve opened this issue Dec 18, 2017 · 0 comments
Assignees

Comments

@spacemansteve
Copy link
Contributor

spacemansteve commented Dec 18, 2017

Facet generation code typically processes multi-token strings. For example, grant agency and grant number are in a single string separated by a space. Currently the code generates an exception if there is no space. It should not.

For invalid strings, the code should simply 'continue' with the next string in the loop (ignoring the current string).

https://github.com/adsabs/ADSMasterPipeline/blob/master/adsmp/solr_updater.py#L27
https://github.com/adsabs/ADSMasterPipeline/blob/master/adsmp/solr_updater.py#L36
https://github.com/adsabs/ADSMasterPipeline/blob/master/adsmp/solr_updater.py#L36

@spacemansteve spacemansteve self-assigned this Dec 18, 2017
@spacemansteve spacemansteve changed the title Facet support for incomplete data Facets with incomplete data Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant