From 7133c0459f0c1551b64ffd3deaf5ce917bc39bd2 Mon Sep 17 00:00:00 2001 From: Stefan Stojanovic Date: Tue, 26 Nov 2024 11:12:34 +0100 Subject: [PATCH] build: avoid compiling with VS v17.12 Refs: https://github.com/nodejs/build/issues/3963 PR-URL: https://github.com/nodejs/node/pull/55930 Refs: https://github.com/nodejs/node/pull/53863 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Jake Yuesong Li Reviewed-By: James M Snell --- vcbuild.bat | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/vcbuild.bat b/vcbuild.bat index f93998d2b14901..59197c1ccc36e3 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -292,10 +292,19 @@ goto exit @rem Visual Studio v17.10 has a bug that causes the build to fail. @rem Check if the version is v17.10 and exit if it is. echo %VSCMD_VER% | findstr /b /c:"17.10" >nul -if %errorlevel% neq 1 ( +if %errorlevel% neq 1 ( echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version. goto exit ) +@rem Same applies to v17.12 for MSVC. +echo %VSCMD_VER% | findstr /b /c:"17.12" >nul +if %errorlevel% neq 1 ( + @rem Clang 18.1.8 Provided with VS 17.12 works fine. + if not defined clang_cl ( + echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version. + goto exit + ) +) @rem check if the clang-cl build is requested if not defined clang_cl goto clang-skip