Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Enhancement]: For series detection by id3 tags, use GRP1 in addition to/instead of TXXX:grouping #3681

Closed
Cantello opened this issue Dec 5, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Cantello
Copy link

Cantello commented Dec 5, 2024

What happened?

According to this comment the grouping tag is used to define series. However, when using abs to embed metadata into mp3 files, it writes the obsolete TXXX:grouping field, instead of the widely accepted GRP1 field, which is used by major id3 taggers (kid3, mp3tag, MusicBrainz Picard) and I cannot edit the tags anymore outside of abs, which kind of defeats the purpose of standardised tags.

What did you expect to happen?

Adiobookshelf recognizes the GRP1 tag when detecting metadata.

Steps to reproduce the issue

  1. Edit series in audiobookshelf
  2. Embed metadata into mp3 files
  3. Try editing with an id3 tagger

Audiobookshelf version

2.17.3

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Firefox

Logs

No response

Additional Notes

According to

file_tag_grouping: tryGrabTags(format, 'grouping'),
the grouping tag is only defined by one property, whereas e.g. Album is defined as file_tag_album: tryGrabTags(format, 'album', 'talb', 'tal'),, Artist as file_tag_artist: tryGrabTags(format, 'artist', 'tpe1', 'tp1'),.
Could the definition of grouping be expanded similarly to file_tag_grouping: tryGrabTags(format, 'grouping', 'grp1'),?

@Cantello Cantello added the bug Something isn't working label Dec 5, 2024
@advplyr
Copy link
Owner

advplyr commented Dec 5, 2024

@Cantello
Copy link
Author

Cantello commented Dec 5, 2024

Does ffprobe detect that tag? https://www.audiobookshelf.org/guides/ffprobe/#inspecting-an-audio-file

Yes, it does (output of ffprobe on a file with the GRP1 tag written):

  [...]
      "title": "Kapitel 1 & Kapitel 2.1 - Tintenwelt 1. Tintenherz",
      "track": "1/63",
      "GRP1": "Tintenwelt",
      "date": "2013-08-01"
  [...]

@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

Fixed in v2.17.4.

@github-actions github-actions bot closed this as completed Dec 5, 2024
@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Dec 5, 2024
@Cantello
Copy link
Author

Cantello commented Dec 6, 2024

Tested and it works, great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants