Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Enable IFRAME activation #3684

Closed
miltuss opened this issue Dec 5, 2024 · 2 comments
Closed

[Enhancement]: Enable IFRAME activation #3684

miltuss opened this issue Dec 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@miltuss
Copy link

miltuss commented Dec 5, 2024

Type of Enhancement

None

Describe the Feature/Enhancement

Since update 2.17.3, IFRAME integration no longer works with ABS. And some Reverse-proxy like Caddy cannot activate ABS IFRAME. An ENV variable could give users the choice of whether or not to activate the IFRAME.

Why would this be helpful?

I use ABS with the Organizr application which integrates other applications in IFRAME

Future Implementation (Screenshot)

.

Audiobookshelf Server Version

2.17.3

Current Implementation (Screenshot)

No response

@miltuss miltuss added the enhancement New feature or request label Dec 5, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Dec 6, 2024
@advplyr
Copy link
Owner

advplyr commented Dec 8, 2024

Since this is a common request I made this a server setting.

image

Allowing iframe embed can also be enabled via an env variable ALLOW_IFRAME with a value of 1.

Note: If it is enabled through the env variable there will be an error message shown when attempting to disable it in server settings. Env variable takes precedence.

Copy link

github-actions bot commented Dec 8, 2024

Fixed in v2.17.5.

@github-actions github-actions bot closed this as completed Dec 8, 2024
@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants