-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Casting from Web app causes file name to be displayed instead of chapter name #3821
Comments
This is going to be tricky since we send chromecast a list of audio files, not chapters. We can do what we do when opening audiobook RSS feeds though. If the audio files and chapters match up then use the chapter title instead of the audio filename. For reference, this is the check that determines whether the RSS feed will use chapter titles: audiobookshelf/server/models/FeedEpisode.js Lines 112 to 128 in 64e9ac9
This is the same issue that we have for the Android app notification player and android auto. advplyr/audiobookshelf-app#489 advplyr/audiobookshelf-app#239 advplyr/audiobookshelf-app#729 (comment) It is common that when passing audio tracks to another "service" they expect a list of audio tracks and give you the option to set the title for that audio track. They are taking care of navigating between tracks. |
Understood. It's not a showstopper issue. |
What happened?
I was testing casting from the Web application to my television, and noticed that the file name was being displayed instead of the chapter name.
The full file name is 18 - The Walls Have Ears - Chapter 14 British Intelligence, POWs and War Crimes Trials.m4b
What did you expect to happen?
I was expected the actual chapter name as configured in ABS to be displayed (e.g. British Intelligence, POWs and War Crimes Trials)
Steps to reproduce the issue
Start the Cast from the web browser.
Audiobookshelf version
2.17.7
How are you running audiobookshelf?
Docker
What OS is your Audiobookshelf server hosted from?
Linux
If the issue is being seen in the UI, what browsers are you seeing the problem on?
Chrome
Logs
Additional Notes
Issue is replicated on Android app as well per advplyr/audiobookshelf-app#1432
The text was updated successfully, but these errors were encountered: