Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses some of the CBR/CBZ issues.
As mentioned in #2750, the memory does not get freed until after the comics have completed parsing. This PR adds the
archive.close()
call at the end of the extraction functions.I tested this by:
zip
andrar
bash utilities)I don't have any "real" comics, so additional testing should be done on
edge
before this is part of a full release. My homemade comics did not actually load in the ereader, but were parsed during the scan.