Rename :asset-path

[martinklepsch]

Asset path has been confusing many esp. since it's also overlapping with a compiler option. I recently "discovered" that what it's doing is actually conceptually similar to the :root option in compojure's resource handler. So with that in mind maybe :resource-root would make sense?

Just a thought in any case we should definitely hear from users if this would have cleared things up.

[Deraen]

Resource-root sounds good!

We could also change the implementation a bit to be more similar to it:

If I recall correctly current asset-path removes the path from start of the URL being reloaded, if the URL doesn't start with asset-path, it is used as is.

Resource-root could work so that ONLY files inside those paths are reloaded.

Resource-root could perhaps also be a collection?

[arichiardi]

My 2c, a resource path in Java is something very particular, at the moment I don't recall the use of :asset-path option exactly, just saying that it might be confusing as well...

[js-choi]

As @arichiardi says, the word “resource” does mean something different in Java parlance—and, indeed, Boot’s API itself uses the word in that other way too. This overloading of “resource” may be unnecessarily confusing to many users of Java and Boot.

My preference would be to alias :asset-path to :output-dir, like @esessoms’s original proposal in #65. I think this would match the mental model of the typical ClojureScript user better. After all, every ClojureScript user is familiar with the standard compiler options. I don’t seem much of a downside to aliasing :asset-path to :output-dir, which would maintain backwards compatibility (as opposed to also renaming :cljs-asset-path to :asset-path, which would also be nice but would be a breaking change.)

Eventually, as @Deraen says, it would be great if boot-reload inferred the compiler’s output directory and asset URL paths. When I have time, I might try to contribute an implementation of that myself…though I’d probably have to finally properly learn how Boot pods work, heh.