Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional storage parameters #68

Open
kvaps opened this issue Mar 22, 2024 · 3 comments
Open

Additional storage parameters #68

kvaps opened this issue Mar 22, 2024 · 3 comments

Comments

@kvaps
Copy link
Member

kvaps commented Mar 22, 2024

From here #67 (comment)

The new spec looks good good. The only question if we do this:

storage:
   volumeClaimTemplate:
     metadata:
       labels:
         env:prod
       annotations:
         example.com/annotation: "true"
     spec: # core.v1.PersistentVolumeClaimSpec Ready k8s type
       storageClassName: gp3
       accessModes: ["ReadWriteOnce"]
       resources:
         requests:
           storage: 10Gi
   emptyDir: {} # core.v1.EmptyDirVolumeSource Ready k8s type

then where will we add the possible options in the future:

  1. auto-deletion of PVC after deleting the EtcdCluster object
  2. options for resizing PVC (resizeInUseVolumes as CNPG and mariadb-operator do
  3. option to manage storage migration
  4. any other options for storage in the future
@kvaps
Copy link
Member Author

kvaps commented Mar 22, 2024

I'm thinking about additional level, something like this:

storage:
  resizeInUseVolumes: true
  additionalOptionHere: true
  volume: # OneOf
    emptyDir: {}
    volumeClaimTemplate: {}

What is your ideas?

@AlexGluck
Copy link
Collaborator

Point 1 and 2 agree, but in point 3 how was work storage migration logic? Before anyone give suggestions we don't must change spec.
And for point 4 it is premature optimization.

@kvaps
Copy link
Member Author

kvaps commented Mar 26, 2024

storage:
  resizeInUseVolumes: true
  additionalOptionHere: true
  emptyDir: {}
  volumeClaimTemplate: {}

@kvaps kvaps removed this from the v0.0.2 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants