Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Experimental: TDE using SFA_FAST #125

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[ENH] Experimental: TDE using SFA_FAST #125

wants to merge 6 commits into from

Conversation

patrickzib
Copy link
Contributor

This is PR refactors TDE to use SFA_FAST.

  • Added a new class _tde_fast.py with FastTemporalDictionaryEnsemble
  • Removed Multivariate support for now
  • Runtime still not optimal

@patrickzib patrickzib added enhancement New feature, improvement request or other non-bug code enhancement classification Classification package labels Feb 28, 2023
@patrickzib patrickzib marked this pull request as ready for review February 28, 2023 12:14
@patrickzib patrickzib changed the title [ENH] TDE using SFA_FAST [ENH] Experimental: TDE using SFA_FAST Feb 28, 2023
@patrickzib
Copy link
Contributor Author

Histogram Intersection is expensive...

image

@TonyBagnall
Copy link
Contributor

this is interesting, but should it be a draft PR?

@patrickzib
Copy link
Contributor Author

patrickzib commented Feb 28, 2023 •
edited
Loading

Yes, a draft would be better. but does a draft run ci?

@patrickzib patrickzib marked this pull request as draft February 28, 2023 17:41
patrickzib and others added 5 commits March 14, 2023 19:34
@MatthewMiddlehurst
Copy link
Member

Ah didnt actually mean to push that, was doing some tidying using this as a base 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyBagnall TonyBagnall Awaiting requested review from TonyBagnall TonyBagnall is a code owner

@MatthewMiddlehurst MatthewMiddlehurst Awaiting requested review from MatthewMiddlehurst MatthewMiddlehurst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickzib @TonyBagnall @MatthewMiddlehurst