You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couldn't verify the correctness due to a lack of alternate implementations. I shall continue to work on this once we track down an alternate implementation?
I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#5209C9}{\textsf{distances}}$ ]. Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeonSlack channel if you have any.
@MatthewMiddlehurst From my side this looks ready to go. However, I'm not 100% confident about the logic used. We should check this up against an alternate implementation (which I couldn't track down) if something looks wrong to you. :-)
so the implementation is true to the definition in the paper, but I dont think defining this recursively is a good idea. It would be better if it followed the model used by LCSS. @chrisholder and I will take a look and get back to you
There seems to be a conflict which has to be resolved, but @chrisholder has approved so this should be quick to merge after given him and @TonyBagnall have no issues with it.
distancesDistances packageenhancementNew feature, improvement request or other non-bug code enhancement
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aeon-actions-bot
bot
added
distances
Related to: #425
Implemented as per this paper, Section 5.
Couldn't verify the correctness due to a lack of alternate implementations. I shall continue to work on this once we track down an alternate implementation?