-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Adds class_weight to those classifier that support it. Required for imbalanced datasets. #1776
Conversation
Thank you for contributing to
|
There was also a bug in Quant (not Hydra), as the random_state parameter was not passed to the classifier. Now fixed |
i think you mean you fixed the random_state thing in quant, not hydra @patrickzib no ? |
Uh, yes :) |
will raise an issue to keep in mind doing this for the rest of classifiers as lots others use sklearn based estimators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! check #1777 for the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, be interested to see if it makes any difference. Just saw the conflict
1a93ef2
Thank you @TonyBagnall @hadifawaz1999 . Would you mind approving again? I had to merge main. |
class_weight
to those classifiers that support it by sklearn design.class_weight
is intended for training with imbalanced datasets.From ExtraTreesClassifier:
random_state parameter
was not passed to the internal estimator.