Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

_yoink_item in pickit.py has faulty logic when teleporting with charges #929

Open
andrewdudzik opened this issue Jun 23, 2022 · 0 comments

Comments

@andrewdudzik
Copy link

andrewdudzik commented Jun 23, 2022

Walking characters and those teleporting with charges do very weird things when picking up items since 8.0, so I looked into it.

  • When _yoink_item is called with force_tp = True, this parameter is passed to char.move as force_move = force_tp. As a result, a teleport is not forced and a character teleporting with charges will always walk.

  • Even if force_tp is passed, a character teleporting with charges still won't teleport, since the code expects a call to char.select_tp(), as is done in pather.py.

  • In general, the wait(0.09, 0.12) is so tiny that the yoink will fail almost any time the character is not teleporting, since they will immediately click back to the center of the screen. This includes the non-teleporting call to yoink (line 125) whenever the item is far enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants