Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace with or Wrap rbuf #1

Open
freb opened this issue Dec 28, 2018 · 1 comment
Open

Replace with or Wrap rbuf #1

freb opened this issue Dec 28, 2018 · 1 comment

Comments

@freb
Copy link
Contributor

freb commented Dec 28, 2018

I found an interesting ring buffer lib. Originally, I was thinking I would use it to replace our own forked circbuf lib. However, rbuf has a Read method which makes it a reader. It also has some methods similar to this library. If it has what we need, we could replace this library with it entirely. If it doesn't this library should just become a light weight wrapper.

@freb
Copy link
Contributor Author

freb commented Feb 13, 2019

I don't actually think that rbuf will offer us much by way of performance since it turns out the performance of unread isn't bad after wrapping the underlying reader in a buffio.Reader. I think the ping-pong buffers in rbuf mainly make a difference doing specific types of reads, but I could be wrong. Still worth looking into, but not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant