Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New updated metrics spi for Keycloak 24 #198

Open
GSXswe opened this issue Apr 10, 2024 · 11 comments
Open

New updated metrics spi for Keycloak 24 #198

GSXswe opened this issue Apr 10, 2024 · 11 comments

Comments

@GSXswe
Copy link

GSXswe commented Apr 10, 2024

Description

Need new updated metrics spi with support for Keycloak 24.

Environment

  • Keycloak 24.0.2
@doggy-dev
Copy link

Does version 5.0.0 work with Keycloak v24?

@GSXswe
Copy link
Author

GSXswe commented Apr 17, 2024

After some testing it seems like the code does support v24, more testing is needed.

@alplunge
Copy link

Does it work or not really ? @cturkalj any news about this one ?

@GSXswe
Copy link
Author

GSXswe commented Apr 29, 2024

It works for us, we are getting metrics. :-)

@alplunge
Copy link

@GSXswe are you using tagged version 5.0? and simply included metrics as extension without any additional fiddling?

@cturkalj
Copy link
Contributor

@alplunge , it works for me as well (the official 5.0.0 release version) without any additional fiddling

@alplunge
Copy link

alplunge commented Apr 30, 2024

@cturkalj I have one following question, is there any reason why only POM got updated with quarkus-resteasy-reactive for compatibility aede7e0 ?

@cturkalj
Copy link
Contributor

@alplunge: I am not sure I understand your question. The MetricsFilterProvider was updated for compatibility with Keycloak 23 (it needed to work with resteasy reactive for proper filter registration) .

@alplunge
Copy link

alplunge commented Apr 30, 2024

@cturkalj sorry for not being specific enough, shouldn't build.gradle be also be updated for gradle builds?

@cturkalj
Copy link
Contributor

@alplunge: You're right, I didn't use gradle - I used maven.
But I don't know the release process. I assume it uses maven (@pb82 probably knows).
It doesn't matter if you use the released version, since it is a povided dependency.
You should create a PR to update the gradle build file.

@amasiero
Copy link

@GSXswe, can you give me a direction here? I'm facing the same "issue" with the same version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants