Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Automattic/_s
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: afercia/_s
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 2, 2013

  1. WP_Widget_Archives accessibility

    For accessibility (and valid code), every form control should be correctly associated with a label. Here, the Archives Widget select doesn't have any label, not even a form element. Easy to fix modifying $archive_content variable and using "after_widget".
    afercia committed Sep 2, 2013

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    966a784 View commit details
Showing with 3 additions and 3 deletions.
  1. +3 −3 404.php
6 changes: 3 additions & 3 deletions 404.php
Original file line number Diff line number Diff line change
@@ -42,8 +42,8 @@

<?php
/* translators: %1$s: smiley */
$archive_content = '<p>' . sprintf( __( 'Try looking in the monthly archives. %1$s', '_s' ), convert_smilies( ':)' ) ) . '</p>';
the_widget( 'WP_Widget_Archives', 'dropdown=1', "after_title=</h2>$archive_content" );
$archive_content = '<form action="' . esc_url( home_url( '/' ) ) . '" method="post"><label>' . sprintf( __( 'Try looking in the monthly archives. %1$s', 'expound' ), convert_smilies( ':)' ) ) . '<br>';
the_widget( 'WP_Widget_Archives', 'dropdown=1', "after_title=</h2>$archive_content&after_widget=</label></form></div>" );
?>

<?php the_widget( 'WP_Widget_Tag_Cloud' ); ?>
@@ -54,4 +54,4 @@
</main><!-- #main -->
</div><!-- #primary -->

<?php get_footer(); ?>
<?php get_footer(); ?>