Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build against latest version #4

Open
carbontwelve opened this issue May 24, 2017 · 4 comments
Open

Fails to build against latest version #4

carbontwelve opened this issue May 24, 2017 · 4 comments

Comments

@carbontwelve
Copy link

carbontwelve commented May 24, 2017

TCOD_sys_set_keyboard_repeat and TCOD_sys_disable_keyboard_repeat were removed in version 1.6.2 due to the removal of SDL1 support.

This therefore breaks your bindings when used against the latest version of libtcod.

There is no other API breaks that I can see, so removing those bindings may make it work with the latest version?

When attempting to go get the current version:

simon@golang-dev:~/libtcod/build/autotools$ go get github.com/afolmert/libtcod-go/tcod
# github.com/afolmert/libtcod-go/tcod
/tmp/go-build439497172/github.com/afolmert/libtcod-go/tcod/_obj/tcod.cgo2.o: In function `_cgo_c32c775d42f7_Cfunc_TCOD_console_disable_keyboard_repeat':
../../../go/src/github.com/afolmert/libtcod-go/tcod/cgo-gcc-prolog:448: undefined reference to `TCOD_console_disable_keyboard_repeat'
/tmp/go-build439497172/github.com/afolmert/libtcod-go/tcod/_obj/tcod.cgo2.o: In function `_cgo_c32c775d42f7_Cfunc_TCOD_console_set_keyboard_repeat':
../../../go/src/github.com/afolmert/libtcod-go/tcod/cgo-gcc-prolog:1053: undefined reference to `TCOD_console_set_keyboard_repeat'
collect2: error: ld returned 1 exit status

I forked and removed the undefined references and go get completed without error, but it looks as though the API has changed enough that a fair bit of work is needed to update the bindings. Oh well.

@Zireael07
Copy link

Which libtcod version do you mean when saying "latest"?

@carbontwelve
Copy link
Author

@Zireael07 at time of writing latest would have been version 1.6.2 of libtcod.

@wizzardx
Copy link

Same problem with libtcod 1.7.0

@carbontwelve
Copy link
Author

carbontwelve commented Nov 2, 2018

@wizzardx

Same problem with libtcod 1.7.0

The problem is because this library was written against an older version of . libtcod and hasn't been kept up to date with the changes in libtcod's api. Therefore as of the time of my first reporting the issue this package is broken unless you roll back your version of libtcod to one that it was written against.

Looking at it, you will need to build against version 1.5.1 of libtcod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants