-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[object Object] instead of color for topColor bottomColor a-sky created from environment component #743
Comments
The Adding a specialized |
Yeah that would be a breaking change for sure, it will break here for example Also in which color space would you create the This change is a recent commit supermedium/aframe-environment-component@f972abe so we didn't have the [object Object] issue here before. Can we just implement stringify for the color type to produce |
It would apply the same logic as THREE does out of the box. So string based colours (CSS names, hex codes, etc...) are assumed to be sRGB and will be converted upon parsing into the working colour space. Components can then convert it to any colour space they might need, or leave it as-is when passing along. When providing an instance of While this might be a nice improvement over string-based colours, I don't think there's a way to introduce this without breaking some components.
Yes, though a more correct approach would actually be to implement a |
The issue is in aframe 1.5.0, 1.6.0 and master.
Same when you copy the entity to clipboard:
It's because the environment component set directly a THREE.Color instance instead of hex color string on those properties, see
https://github.com/supermedium/aframe-environment-component/blob/b339b293139cd8c10f03d4c9a162c3b5ea55a794/index.js#L325-L326
@mrxz maybe you can take a look, that's probably a similar serialization issue than HTMLImageElement.
The text was updated successfully, but these errors were encountered: