Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make navbar responsive on screens with width from 1000px to 1999px #678

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

RahmaaEsmail
Copy link
Contributor

Related Issue

Proposed Changes

-I have changed navbar on screen from width 1999px to 1000px to make it more responsive

Additional Info

  • Any additional information or context

Checklist

  • [x ] ✅ My code follows the code style of this project.
  • 📝 My change requires a change to the documentation.
  • 🎀 I have updated the documentation accordingly.
  • [x ] 🌟 I have starred the repo
  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

I have made navbar links suitable for large screen , and prevent it from go outside the container

#677

I have reduced padding left and right in , and make font size of link is 13px , and make mobile navbar toggle appear from 1000px

Due to a part of the navbar not being visible in screen with 1999px to 991px , I will make all the links in the navbar visible so that I can use them

There is no effect , and when I Checked the website , I found it to be intact because I did not modify any classes that you may hear about in multiple places , but I only modified classes in the navbar

Output Screenshots

image
Screenshot #1 Screenshot #2
Title goes here Title goes here
Image goes here Image goes here

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for codesetgo ready!

Name Link
🔨 Latest commit 390c8ae
🔍 Latest deploy log https://app.netlify.com/sites/codesetgo/deploys/64cd2a842b18c20008072941
😎 Deploy Preview https://deploy-preview-678--codesetgo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@agamjotsingh18 agamjotsingh18 merged commit d7dbc37 into agamjotsingh18:main Aug 4, 2023
4 checks passed
@agamjotsingh18 agamjotsingh18 linked an issue Aug 4, 2023 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc23 level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Bug : Make Navbar links responsive in large screen
2 participants