Skip to content

Tidy up Algebra.Definitions.RawMagma (again), plus reconcile all the uses of _,_ as a constructor #2582

Open
@jamesmckinna

Description

@jamesmckinna

Variations on the theme of uncoupling from Data.Product.Base, lifted out from #2579 : cf. #207

  • bug: we don't give fixities to the various uses of _,_ as a constructor which since Fix #2216 by making divisibility definitions records #2217 supersede the prior use of Data.Product.Base._,_, so it's possible to get some odd parsing errors
  • breaking mutual divisibility currently still defined as a Data.Product.Base._×_,, but since [ new ] symmetric core of a binary relation #2071 , it might be better to redefine it using Relation.Binary.Construct.Interior.Symmetric, and then be able to exploit the generic properties of such relations...
  • bug: the constructor _,_ of Relation.Binary.Construct.Interior.Symmetric.SymInterior also doesn't have a fixity declaration either

Propose:

  • give each use of _,_ as a constructor the same fixity declaration, namely infixr 4 _,_ that of Data.Product.Base._,_ [ fix ] Add correct fixities for constructor uses of _,_ #2584
  • redefine _∥_ and refactor the proofs of its various properties as we go up the hierarchy to Algebra.Properties.Semiring.Divisibility (downstream PR)

It's possible that these should be two issue: the #207 bug fixes , and then the divisibility refactoring.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions