Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files should not import things public #569

Open
mortberg opened this issue Jun 9, 2021 · 1 comment
Open

Files should not import things public #569

mortberg opened this issue Jun 9, 2021 · 1 comment
Labels
order Structuring, enforcing conventions, renaming, ...

Comments

@mortberg
Copy link
Collaborator

mortberg commented Jun 9, 2021

Some files import things public which can cause problems later when renaming and refactoring. We should get rid of all public imports that are not crucial (for example the Prelude should expose all of Core.Primitives so that we don't have to import it everywhere). It would be good with a PR which does only this and adds a bullet about it to the style guide

@felixwellen felixwellen added the order Structuring, enforcing conventions, renaming, ... label May 22, 2022
@felixwellen
Copy link
Collaborator

We have the bullet point in CONTRIBUTING.md. So it remains to be checked, if there are still public imports that should not be public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
order Structuring, enforcing conventions, renaming, ...
Projects
None yet
Development

No branches or pull requests

2 participants