Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filter Manual enter data] Step #12

Closed
batical opened this issue Oct 14, 2020 · 5 comments · Fixed by #58
Closed

[Filter Manual enter data] Step #12

batical opened this issue Oct 14, 2020 · 5 comments · Fixed by #58
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@batical
Copy link
Contributor

batical commented Oct 14, 2020

Is your feature request related to a problem? Please describe.
I would like to filter the manual added data. For exemple get the number of step without manual added data

Describe the solution you'd like
in the options, add a flag to include manual or not

@batical batical added the enhancement New feature or request label Oct 14, 2020
@lucaspbordignon lucaspbordignon added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 14, 2020
@lucaspbordignon
Copy link
Contributor

Hey @batical! Thanks for the suggestion, that's a really valuable addition to the repository. I've also seen that we have the same request added to the original repository but was never really merged to master

We can definitively base our solution on that. The resources are the following

@batical
Copy link
Contributor Author

batical commented Oct 15, 2020

I saw you already made a first commit on this request. thanks

I will check your link for the previous repo

@batical batical closed this as completed Oct 15, 2020
@batical batical reopened this Oct 15, 2020
@lucaspbordignon
Copy link
Contributor

@batical Yeah! I actually noticed that we already have the includeManuallyAdded flag for the getDailyStepCountSamples method, but we can probably filter all the other metrics too based on that flag

Also, feel free to go ahead and create a draft PR in case you need that functionality as soon as possible. I probably won't be able to work on it in the next few days, but can help complete the remaining methods in about a week from now (if any remaining method need to be updated)

@batical
Copy link
Contributor Author

batical commented Oct 16, 2020

I can maybe try to copy from the other PR but I have no real knowledge of ObjC or Swift

@lucaspbordignon
Copy link
Contributor

@batical We do have some great references added in PR #24 too, in case it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants