Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for prepared transactions #173

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Conversation

nerfZael
Copy link
Contributor

@nerfZael nerfZael commented Apr 10, 2024

Closes #97

image

@nerfZael
Copy link
Contributor Author

/workflows/benchmarks agents/token 3

Copy link

github-actions bot commented Apr 10, 2024

Finished benchmarks

Test Run Summary

  • Run from: ./autotx/tests/agents/token
  • Iterations: 3
  • Total Success Rate: 81.48%

Detailed Results

Test Name Success Rate Passes Fails Avg Time
autotx/tests/agents/token/test_swap.py::test_auto_tx_swap_eth 100% 3 0 19s
autotx/tests/agents/token/research/test_research.py::test_get_top_5_most_traded_tokens_from_l1 33% 1 2 38s
autotx/tests/agents/token/research/test_research.py::test_price_change_information 100% 3 0 17s
autotx/tests/agents/token/research/test_research_and_swap.py::test_auto_tx_research_and_swap_meme_token 67% 2 1 27s
autotx/tests/agents/token/research/test_research_and_swap.py::test_auto_tx_research_swap_and_send_governance_token 100% 3 0 57s
autotx/tests/agents/token/send/test_send.py::test_auto_tx_send_erc20_parallel 100% 3 0 27s
autotx/tests/agents/token/send/test_send.py::test_auto_tx_send_eth 100% 3 0 16s
autotx/tests/agents/token/research/test_research.py::test_get_token_exchanges 100% 3 0 22s
autotx/tests/agents/token/research/test_research.py::test_get_top_5_memecoins 67% 2 1 27s
autotx/tests/agents/token/research/test_research.py::test_get_top_5_memecoins_in_optimism 67% 2 1 29s
autotx/tests/agents/token/send/test_send.py::test_auto_tx_send_erc20 100% 3 0 17s
autotx/tests/agents/token/send/test_send.py::test_auto_tx_send_eth_sequential 100% 3 0 26s
autotx/tests/agents/token/test_swap.py::test_auto_tx_swap_with_non_default_token 100% 3 0 14s
autotx/tests/agents/token/test_swap.py::test_auto_tx_swap_multiple 100% 3 0 21s
autotx/tests/agents/token/research/test_research.py::test_check_liquidity 33% 1 2 31s
autotx/tests/agents/token/research/test_research.py::test_get_top_5_tokens_from_base 100% 3 0 42s
autotx/tests/agents/token/test_swap_and_send.py::test_auto_tx_swap_and_send_complex 0% 0 3 32s
autotx/tests/agents/token/test_swap_and_send.py::test_auto_tx_swap_and_send_simple 100% 3 0 21s

Total run time: 24.12 minutes

Copy link
Contributor

@cbrzn cbrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it iterates as expected, but i noticed that when a new transaction is created, the nonce is modified (even tho the previous tx was not executed)

example:
image

this will make the latest transaction created to fail because it doesn't have the correct nonce

autotx/AutoTx.py Outdated Show resolved Hide resolved
@nerfZael nerfZael requested a review from cbrzn April 11, 2024 18:30
@dOrgJelli dOrgJelli merged commit 2248c9c into main Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction Bundle User Feedback
3 participants