Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 99 bug with diagram resize in splitpane #101

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Issue 99 bug with diagram resize in splitpane #101

wants to merge 5 commits into from

Conversation

amivanoff
Copy link
Member

Closes #99

@amivanoff
Copy link
Member Author

I've separated GraphRender story in two stories: without SplitPane and with it, We have some issues with both.

  1. Some strange multiple graphs at the bottom in a DOM tree without new SplitPane styles
    image
  2. In a story with new SplitPane styles diagram somehow renders "behind" and becomes invisible
    image

@amivanoff
Copy link
Member Author

amivanoff commented Sep 9, 2021 •
edited
Loading

This bugs could be reproduced with the latest commit from here and the new ldkg-ui-react from main.
I've added there some pre-checks to ensure that all data is loaded before Graph render and no additional re-renders occured.

@Artkrygin
Copy link
Contributor

  1. These graphs are for preview and DnD
  2. How to recreate this bug? I tried so hard, but couldn't get it.

@amivanoff
Copy link
Member Author

amivanoff commented Sep 22, 2021 •
edited
Loading

Additional minor refactoring in the commit above.
Bug manigests in two stories:

  • Remote Data Graph
  • Remote Data Graph Split Pane

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diagram editor did not respond properly to a SplitPane resize
2 participants
@amivanoff @Artkrygin