Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to download music #233

Open
agersant opened this issue Feb 5, 2025 · 1 comment
Open

Add functionality to download music #233

agersant opened this issue Feb 5, 2025 · 1 comment

Comments

@agersant
Copy link
Owner

agersant commented Feb 5, 2025

  • Individual song
  • Whole directory
  • Whole album
  • Whole playlist

Implementation notes:

  • Probably would best be added in right-click context menus in web UI
  • Look into streaming zip responses without making a temp file on server
@lnicola
Copy link
Contributor

lnicola commented Feb 6, 2025

Look into streaming zip responses without making a temp file on server

I thought this wasn't possible because the local file headers include the uncompressed length. But for music it's probably fine to used "stored" (no-op) compression, and ZIP64 might actually put this in an extra descriptor which sits after the file data.

Anyway, for a similar application I stream TAR, which doesn't have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants