Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fuzz-fuzz.zip from source code #27

Open
cyrilc-pro opened this issue May 21, 2024 · 3 comments · May be fixed by #28
Open

Remove fuzz-fuzz.zip from source code #27

cyrilc-pro opened this issue May 21, 2024 · 3 comments · May be fixed by #28

Comments

@cyrilc-pro
Copy link

cyrilc-pro commented May 21, 2024 •
edited
Loading

This package includes a file fuzz/fuzz-fuzz.zip which includes binaries (sonar.exe, cover.exe). These files are detected as vulnerable by security scanners as they were compiled with Go 1.14.1.
I think this is file should not be committed into Git.
@agnivade
Copy link
Owner

A PR would be most welcome :)

@cyrilc-pro
Copy link
Author

What do you suggest? Can we just remove the zip file?

@agnivade
Copy link
Owner

Historically, Go exe files have been known to raise false vulnerabilities by scanners.

This code was added quite a while back and now there's native fuzzing available in the Go toolchain. It would be great if you want to revamp the entire fuzzing part - remove all the old code, and redo fuzzing using the new way.

Otherwise, I don't think there's a big downside in keeping them.

@hanzei hanzei linked a pull request Jul 1, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement native fuzzing in Go hanzei/levenshtein
2 participants
@agnivade @cyrilc-pro