Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor seerep-core-fb/pb #269

Open
Mark-Niemeyer opened this issue Mar 23, 2023 · 0 comments
Open

refactor seerep-core-fb/pb #269

Mark-Niemeyer opened this issue Mar 23, 2023 · 0 comments
Labels
enhancement New feature or request flatbuffer protobuf ROS ROS related

Comments

@Mark-Niemeyer
Copy link
Member

The only functions of seerep-core-fb and seerep-core-pb are the conversion from the fb/pb to the core msgs and the relaying of the function calls. To remove these packages with little content we could

  1. merge seerep-ros-conversion and the fb/pb to core conversions into a new seerep-conversions package
  2. move the little functionality of seerep-core-fb/pb to sub-methodes in the service implementations of the server
@Mark-Niemeyer Mark-Niemeyer added enhancement New feature or request ROS ROS related protobuf flatbuffer labels Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request flatbuffer protobuf ROS ROS related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mark-Niemeyer