Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fedora luajit version is not compatible with neovim #10

Open
VikramNisarga opened this issue Apr 6, 2021 · 6 comments
Open

Fedora luajit version is not compatible with neovim #10

VikramNisarga opened this issue Apr 6, 2021 · 6 comments

Comments

@VikramNisarga
Copy link

Fedora's luajit is using the build flag -DLUAJIT_ENABLE_LUA52COMPAT to build luajit, which changes the return type of some of the methods whereas the neovim's laujit version is not using this build flag. Because of this some of the neovim's plugins are not working in fedora 34

  • nvim --version:NVIM v0.5.0-dev+1211-g6db3ba9df
  • Operating system/version: Fedora 34 beta
  • Terminal name/version:gnome terminal
  • $TERM:xterm-256color

Steps to reproduce using nvim -u NORC

Execute :lua print(os.execute("mkdir ./test"))

Actual behaviour

returns true exit 0

Expected behaviour

0
@agriffis
Copy link
Owner

agriffis commented Apr 6, 2021

Hi, this repo is only for the COPR nightly builds. These builds are unofficial, they're not associated with either Neovim or Fedora upstreams, and I have no control over luajit.

Could you open a bug at https://bugzilla.redhat.com/ instead? It would be great to get this problem fixed.

@agriffis agriffis closed this as completed Apr 6, 2021
@VikramNisarga
Copy link
Author

VikramNisarga commented Apr 6, 2021 •
edited
Loading

Hi, this repo is only for the COPR nightly builds. These builds are unofficial, they're not associated with either Neovim or Fedora upstreams, and I have no control over luajit.

Could you open a bug at https://bugzilla.redhat.com/ instead? It would be great to get this problem fixed.

Hi,
The issue is only with this copr build, neovim built from source or the appimage version works fine

@agriffis
Copy link
Owner

agriffis commented Apr 6, 2021 •
edited
Loading

I think the appimage (and neovim built from source) bundles its own luajit.

Does Fedora's build of neovim have the problem? (Edit: yes it does)

@agriffis
Copy link
Owner

agriffis commented Apr 6, 2021 •
edited
Loading

Here's the problem in Fedora: https://src.fedoraproject.org/rpms/luajit/c/1d64e7791a9d64bcd58ea7917242b2d481fc4857?branch=rawhide

Unfortunately it seems that Fedora has been building luajit like this for a while, so it will be harder to recommend a fix that doesn't break other software depending on luajit in Fedora. Depending on the extent of the breakage in Neovim plugins, it might be easier to update them instead.

Regardless, this is not something we can fix in the COPR build. Something will need to change in Fedora first.

@agriffis
Copy link
Owner

agriffis commented Apr 6, 2021

@ignatenkobrain Do you have any thoughts about this? The summary is that neovim depends on luajit without -DLUAJIT_ENABLE_LUA52COMPAT but Fedora started building with this flag a couple years ago. We could open a bugzilla but it's not clear to me what the path forward would be, even if we do that.

(This repo is just a COPR build of neovim nightly, but I verified the problem also appears in F34 neovim.)

@agriffis
Copy link
Owner

agriffis commented Apr 6, 2021

I'll reopen the issue, but only for tracking until we find a way to fix this elsewhere. There is nothing we can do in the COPR build.

@agriffis agriffis reopened this Apr 6, 2021
agriffis pushed a commit that referenced this issue Mar 26, 2023
@cryptomilk
fix: snprintf buffer overflow detected by -D_FORTIFY_SOURCE=3 (neovim…
e3dab4b 
…#22780)

Problem:
Wrong buffer size argument passed to snprintf() in set_cmdarg():
	Thread no. 1 (24 frames)
	 #8 snprintf at /usr/include/bits/stdio2.h:54
	 neovim#9 set_cmdarg at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/eval.c:7044
	 #10 apply_autocmds_group at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/autocmd.c:1843
	 #11 apply_autocmds_exarg at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/autocmd.c:1549
	 #12 readfile at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/fileio.c:617
	 #13 buf_reload at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/fileio.c:5038
	 #14 buf_check_timestamp at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/fileio.c:4952
	 #15 check_timestamps at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/fileio.c:4678
	 #16 ex_checktime at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_cmds2.c:765
	 #17 execute_cmd0 at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_docmd.c:1620
	 #18 do_one_cmd at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_docmd.c:2275
	 #19 do_cmdline at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_docmd.c:584
	 #20 ex_execute at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/eval.c:7727
	 #21 execute_cmd0 at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_docmd.c:1620
	 #22 do_one_cmd at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_docmd.c:2275
	 #23 do_cmdline at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_docmd.c:584
	 #24 do_ucmd at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/usercmd.c:1661
	 #25 execute_cmd0 at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_docmd.c:1612
	 #26 do_one_cmd at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_docmd.c:2275
	 #27 do_cmdline at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/ex_docmd.c:584
	 #28 nv_colon at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/normal.c:4058
	 #29 normal_execute at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/normal.c:1172
	 #30 state_enter at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/state.c:88
	 #31 normal_enter at /usr/src/debug/neovim-0.8.2-2.fc38.x86_64/src/nvim/normal.c:471

Solution:
Subtract the offset from the buffer size.

Signed-off-by: Andreas Schneider <[email protected]>
agriffis pushed a commit that referenced this issue Apr 22, 2023
@cryptomilk
fix(usercmd): Fix buffer overflow in uc_list() (neovim#23225)
9e79f74 
fix(usercmd): fix buffer overflow in uc_list()

Build with: -Wp,-D_FORTIFY_SOURCE=3 -O1 and gcc 13.

*** buffer overflow detected ***: terminated

(gdb) bt
  #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
  #1  0x00007f3eb8b93c03 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
  #2  0x00007f3eb8b42aee in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
  #3  0x00007f3eb8b2b87f in __GI_abort () at abort.c:79
  #4  0x00007f3eb8b2c60f in __libc_message (fmt=fmt@entry=0x7f3eb8ca72e6 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:150
  #5  0x00007f3eb8c27b29 in __GI___fortify_fail (msg=msg@entry=0x7f3eb8ca728c "buffer overflow detected") at fortify_fail.c:24
  #6  0x00007f3eb8c26364 in __GI___chk_fail () at chk_fail.c:28
  #7  0x00007f3eb8c25f45 in ___snprintf_chk (s=s@entry=0x55b8c7c096a5 <IObuff+5> "t' item", maxlen=maxlen@entry=1025, flag=flag@entry=2, slen=slen@entry=1020, format=format@entry=0x55b8c7b872a6 "%ldc") at snprintf_chk.c:29
  #8  0x000055b8c7aea59f in snprintf (__fmt=0x55b8c7b872a6 "%ldc", __n=1025, __s=0x55b8c7c096a5 <IObuff+5> "t' item") at /usr/include/bits/stdio2.h:54
  neovim#9  uc_list (name=name@entry=0x55b8c8351788 "Explore", name_len=name_len@entry=7) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/usercmd.c:534
  #10 0x000055b8c7aeb8a0 in ex_command (eap=0x7fffdc350e60) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/usercmd.c:1009
  #11 0x000055b8c7972537 in execute_cmd0 (retv=retv@entry=0x7fffdc350e54, eap=eap@entry=0x7fffdc350e60, errormsg=errormsg@entry=0x7fffdc350e58, preview=preview@entry=false) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/ex_docmd.c:1620
  #12 0x000055b8c7975c55 in do_one_cmd (cmdlinep=cmdlinep@entry=0x7fffdc3510b8, flags=flags@entry=0, cstack=cstack@entry=0x7fffdc351140, fgetline=fgetline@entry=0x55b8c79882b8 <getexline>, cookie=cookie@entry=0x0) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/ex_docmd.c:2279
  #13 0x000055b8c79767fe in do_cmdline (cmdline=<optimized out>, fgetline=0x55b8c79882b8 <getexline>, cookie=0x0, flags=0) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/ex_docmd.c:578
  #14 0x000055b8c7a17463 in nv_colon (cap=0x7fffdc351780) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/normal.c:3228
  #15 0x000055b8c7a11b35 in normal_execute (state=0x7fffdc351700, key=<optimized out>) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/normal.c:1196
  #16 0x000055b8c7ab0994 in state_enter (s=0x7fffdc351700) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/state.c:99
  #17 0x000055b8c7a0ef68 in normal_enter (cmdwin=false, noexmode=false) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/normal.c:497
  #18 0x000055b8c78a0640 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/neovim-0.9.0-1.fc38.x86_64/src/nvim/main.c:641
@agriffis agriffis removed the bug label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agriffis @VikramNisarga