Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In "RET lookup for the word", RET should be C-c C-o #9

Open
xuchunyang opened this issue Jun 20, 2019 · 5 comments
Open

In "RET lookup for the word", RET should be C-c C-o #9

xuchunyang opened this issue Jun 20, 2019 · 5 comments

Comments

@xuchunyang
Copy link
Contributor

(define-key mw-thesaurus-mode-map [remap org-open-at-point] #'mw-thesaurus--lookup-at-point)

org-open-at-point is bound to C-c C-o not RET by default. Maybe you just want to bind RET directly without remap?

@agzam
Copy link
Owner

agzam commented Jun 20, 2019

In evilified buffers RET is bound to org-open-at-point. So doing this I think will break it for Spacemacs and Doom users.

@xuchunyang
Copy link
Contributor Author

I've never used Evil. If you want to RET, you can just use it, it should work for everybody, right? e.g.,

(define-key mw-thesaurus-mode-map (kbd "RET") #'mw-thesaurus--lookup-at-point)

@agzam
Copy link
Owner

agzam commented Jun 21, 2019

No, I'm pretty sure that's the reason why I did it that way in the first place. I wanted it to be in Org-mode, using outline worked, but it wasn't looking as nice, and in evilified org-mode buffer, RET wouldn't work as I wanted. I know, that's probably not the right way, but it works.

@xuchunyang
Copy link
Contributor Author

You want RET to run mw-thesaurus--lookup-at-point, right?

and then

(define-key mw-thesaurus-mode-map (kbd "RET") #'mw-thesaurus--lookup-at-point)

doesn't work for you?

@mooseyboots
Copy link

i also have this issue. not using evil, RET doesn't work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants