Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull commits from Rallysf fork #10

Closed
joeytheman opened this issue Oct 23, 2012 · 5 comments
Closed

Pull commits from Rallysf fork #10

joeytheman opened this issue Oct 23, 2012 · 5 comments

Comments

@joeytheman
Copy link

Can you take a look at Rallysf branch and see about pulling in some of their commits?

I believe rallysf@8ac3725 will solve issues #6 and #8.
@joeytheman
Copy link
Author

I forked Rallysf branch and fixed the test framework among a few other changes. Let me know if you would like pull requests. https://github.com/joeytheman/cashier.git

@ahawkins
Copy link
Owner

ahawkins commented Nov 3, 2012

Can you send a PR? The commit looks good.

EDIT: Nevermind. This repo doesn't even have cashier/application_controller nor does it integrate directly with ActionController. What's the point?

@joeytheman
Copy link
Author

They changed a few things. See 641e1f4 .

@joeytheman
Copy link
Author

Any update on this?

@ahawkins
Copy link
Owner

@joeytheman have them send a PR and I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahawkins @joeytheman