Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: (Configurable) link-unfurling for GitHub Enterprise links to source-code #120

Open
ELLIOTTCABLE opened this issue Jun 24, 2022 · 1 comment

Comments

@ELLIOTTCABLE
Copy link

I'd love to see links of the following forms expanded to inline, language-highlighted source-code:

- https://git.our-github-enterprise.com/anorg/arepo/blob/abranch/path/to/file.ml#L22-L27
- https://git.our-github-enterprise.com/anorg/arepo/commit/99046b102fdb1df2d1bb297328d953faf70d3e3a#diff-5a77bbcd0815bef116f8d229276915e0522f3f271c169a5ffe55b7ebf23a739cR23-R26
- https://git.our-github-enterprise.com/anorg/arepo/pull/11111/files#diff-5a77bbcd0815bef116f8d229276915e0522f3f271c169a5ffe55b7ebf23a739cR28-R32
- https://git.our-github-enterprise.com/anorg/arepo/pull/11111/commits/99046b102fdb1df2d1bb297328d953faf70d3e3a#diff-5a77bbcd0815bef116f8d229276915e0522f3f271c169a5ffe55b7ebf23a739cR28-R32

There was some discussion of this in our Slack; this has to eventually be handled somewhat delicately, as it's possible for this feature to "leak" code that the Slack-poster shouldn't have access to.

At first blush, the best solution is probably a simple repo/channel whitelist; eventually, mapping of Slack-user to GitHub-user may be necessary.

@yasunariw
Copy link
Collaborator

thanks! we can always make more link types unfurlable, same with #119

language-highlighted

Slack doesn't support highlighting:-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants