Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Auto-display acronym definition" doesn't work for Acronyms with periods #1299

Open
curtischong opened this issue Feb 4, 2025 · 3 comments

Comments

@curtischong
Copy link

The "Auto-display acronym definition" feature is the one described here: #584.

This is a REALLY useful feature so thank you for implementing it!

Unfortunately, when the acronym has periods in it (e.g. when the reference is styled like: (S.U.N.)), it fails to match. I'd love for this feature to also work with acronyms with periods!

Thank you for reading this!

@curtischong curtischong changed the title [Feature Request] "Auto-display acronym definition" doesn't work for Acronyms with periods Auto-display acronym definition" doesn't work for Acronyms with periods Feb 4, 2025
@curtischong curtischong changed the title Auto-display acronym definition" doesn't work for Acronyms with periods "Auto-display acronym definition" doesn't work for Acronyms with periods Feb 4, 2025
@ahrm
Copy link
Owner

ahrm commented Feb 4, 2025

Can you give an example document?

@curtischong
Copy link
Author

https://arxiv.org/pdf/2312.03687is my example. The acronym is " MatterGen more than doubles the percentage of generated stable, unique, and novel (S.U.N.) materials".

I Realized that it's really challenging to do it for my case because "stable, unique, and novel" has "and" in between the second and last word, making it harder to match. If a lot more people upvote this issue it might be worth fixing!

@ahrm
Copy link
Owner

ahrm commented Feb 5, 2025

Added support for abbreviations with dots in c4a960d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants