-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the User
Class
#136
Comments
User
Class to Pydantic Models DirectoryUser
Class
What are the gains of making the User class into a pydantic model? (I'm not super familiar with pydantic) |
Doesn't have to be a pydantic model. I think its data is not even coming from db json so never mind that. |
Some of the data is coming from the DB. However, we use a We primarily use it to fetch the container_client of a specific user. This way, the BE doesn't need to know what is the implementation of this specific container. However, it is not always the user's container which is the destination of the upload (see this comment for more explanation) The class could be expanded in the future to enable for more actions (ex: #172) |
Understood. Fixing the functions is enough in this case, strictly in the context of the present issue. Issue updated. |
Based on recent Discussion, this was mostly through the #224 Epic. I suggest to review the needs of this issue once the Epic finished |
Description
The
User
class, currently located in thedatastore
module, needs to be refactored. Specifically, the methodget_user_container_client
is not being called with the correct parameters.Tasks
get_user_container_client
method in theget_container_client
function.The text was updated successfully, but these errors were encountered: