Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up docker helper for loading #66

Open
rngadam opened this issue Dec 1, 2023 · 0 comments · May be fixed by #68
Open

Clean up docker helper for loading #66

rngadam opened this issue Dec 1, 2023 · 0 comments · May be fixed by #68
Labels
good first issue Good for newcomers

Comments

@rngadam
Copy link
Contributor

rngadam commented Dec 1, 2023

From issue #65

The Dockerfile is designed to be built by:

https://github.com/ai-cfia/ailab-db/blob/main/bin/build-dataloader.sh

and run with the help of these scripts in bin/ such as:

https://github.com/ai-cfia/ailab-db/blob/main/bin/load-data-container.sh

where a volume containing the schema and data dump is provided to mount on /data; volume created from:

https://github.com/ai-cfia/ailab-db/blob/main/bin/build-data-volume.sh

  • this could be made clearer by moving the Dockerfile to bin/ and adding a comment at the top of the Dockerfile explaining how it is used

  • ensure that we have a test making sure this flows work on a sample schema.sql and small dataset within the continuous build.

Originally posted by @rngadam in #65 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants