issue #221: .env.secrets & .env.config #222
Conversation
github-actions
bot
added
the
documentation
k-allagbe
force-pushed
the
221-secretsenv-and-configenv
branch
2 times, most recently
from
0d92dfe to
30f3957
Compare
k-allagbe
force-pushed
the
221-secretsenv-and-configenv
branch
from
30f3957 to
f5c3bd0
Compare
|
@ThomasCardin this works perfectly locally. I have issues running it in a docker container however. The |
secrets.env.template
Outdated
| FERTISCAN_DB_URL= | ||
|
|
||
| # Blob Storage | ||
| FERTISCAN_STORAGE_URL= |
There was a problem hiding this comment.
Do you think it would be possible to store both the username and password instead of the full URL for the secrets.env.template file? Full url's are quite hard to manage with the git-secrets tool
There was a problem hiding this comment.
I agree we should be splitting this up and building the string in code at runtime if we need to use the string
There was a problem hiding this comment.
Done. Note that the modifications to the code are so that the tests no longer require secrets.
There was a problem hiding this comment.
@k-allagbe Do we want to implement the proposed changes to include the username and password in the .env.secrets.template file, or is there a technical constraint? I ask because I still see FERTISCAN_DB_URL in the .env.secrets.template file, and I don’t see any updates in the code showing that the database username and password are being used to construct the connection string.
k-allagbe
force-pushed
the
221-secretsenv-and-configenv
branch
from
1078236 to
8e6ed91
Compare
k-allagbe
force-pushed
the
221-secretsenv-and-configenv
branch
2 times, most recently
from
ee1c5f1 to
f1d31c5
Compare
k-allagbe
force-pushed
the
221-secretsenv-and-configenv
branch
from
f1d31c5 to
8856305
Compare
k-allagbe
changed the title
k-allagbe
force-pushed
the
221-secretsenv-and-configenv
branch
from
8856305 to
059ccce
Compare
|
@ai-cfia/fertiscan please review when you can. |
No description provided.