From b70b33d53444722f2f96480cffcd04df3729dc3c Mon Sep 17 00:00:00 2001 From: CFIALeronB <133677161+CFIALeronB@users.noreply.github.com> Date: Tue, 3 Oct 2023 14:13:34 -0400 Subject: [PATCH 1/8] Renaming package-lock.json and package.json name variables to finesse instead of louis-finesse --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6b53a08..668c07d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,11 +1,11 @@ { - "name": "louis-finesse", + "name": "finesse-frontend", "version": "0.1.0", "lockfileVersion": 3, "requires": true, "packages": { "": { - "name": "louis-finesse", + "name": "finesse", "version": "0.1.0", "dependencies": { "@saithodev/ts-appversion": "^2.2.0", diff --git a/package.json b/package.json index e3e9f4a..530b559 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "louis-finesse", + "name": "finesse-frontend", "version": "0.1.0", "private": true, "dependencies": { From d5fa23942b1c00eb15b664d279bf17dc772ea004 Mon Sep 17 00:00:00 2001 From: CFIALeronB <133677161+CFIALeronB@users.noreply.github.com> Date: Mon, 23 Oct 2023 10:24:28 -0400 Subject: [PATCH 2/8] Update postCreateCommand for npm and ts-appversion - Added @saithodev/ts-appversion to post-create installation. --- .devcontainer/devcontainer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 662ff8e..c3e5bb5 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -4,7 +4,7 @@ "name": "Finesse Frontend Node.js project", // Use 'postCreateCommand' to run commands after the container is created. "image": "mcr.microsoft.com/devcontainers/javascript-node:0-18", - "postCreateCommand": "npm install -g npm@9.8.1 --force", + "postCreateCommand": "npm install -g npm@9.8.1 --force && npm i @saithodev/ts-appversion", // Configure tool-specific properties. // "customizations": {}, From 0dab71ee0c242df9f6793b60f6ffb545a0bd134c Mon Sep 17 00:00:00 2001 From: CFIALeronB Date: Mon, 23 Oct 2023 11:06:29 -0400 Subject: [PATCH 3/8] Removed 'engines' field from package.json to resolve postCreateCommand error failing issue - Resolved the npm version conflict that was preventing a succesful package installation in dev container. - 'saithodev/ts-appversion' can now be installed without issues. #25 --- package.json | 4 ---- src/_versions.ts | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index e3e9f4a..250bd07 100644 --- a/package.json +++ b/package.json @@ -57,9 +57,5 @@ "eslint-config-prettier": "^8.9.0", "eslint-config-standard-with-typescript": "^37.0.0", "eslint-plugin-prettier": "^5.0.0" - }, - "engines" : { - "npm" : "^9.8.1", - "node" : "^18.16.0" } } diff --git a/src/_versions.ts b/src/_versions.ts index 613422f..d8757cf 100644 --- a/src/_versions.ts +++ b/src/_versions.ts @@ -11,8 +11,8 @@ export interface TsAppVersion { export const versions: TsAppVersion = { version: '0.1.0', name: 'louis-finesse', - versionDate: '2023-07-27T19:01:19.184Z', - gitCommitHash: '4eed505', - versionLong: '0.1.0-4eed505', + versionDate: '2023-10-23T15:10:05.957Z', + gitCommitHash: '23ecae9', + versionLong: '0.1.0-23ecae9', }; export default versions; From f36b0c4abc7e34938456a52b23496d0ebd178f38 Mon Sep 17 00:00:00 2001 From: CFIALeronB Date: Mon, 23 Oct 2023 16:10:50 -0400 Subject: [PATCH 4/8] Revert "Merge pull request #26 from ai-cfia/#25_UpdatepostCreateCommand" This reverts commit 3208cd0dd080bfb57f47777368304e51df242176, reversing changes made to 8a5ce53184375b6867987a840d3510cf3428b65d. --- .devcontainer/devcontainer.json | 2 +- package.json | 4 ++++ src/_versions.ts | 6 +++--- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index c3e5bb5..662ff8e 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -4,7 +4,7 @@ "name": "Finesse Frontend Node.js project", // Use 'postCreateCommand' to run commands after the container is created. "image": "mcr.microsoft.com/devcontainers/javascript-node:0-18", - "postCreateCommand": "npm install -g npm@9.8.1 --force && npm i @saithodev/ts-appversion", + "postCreateCommand": "npm install -g npm@9.8.1 --force", // Configure tool-specific properties. // "customizations": {}, diff --git a/package.json b/package.json index e239c7b..530b559 100644 --- a/package.json +++ b/package.json @@ -57,5 +57,9 @@ "eslint-config-prettier": "^8.9.0", "eslint-config-standard-with-typescript": "^37.0.0", "eslint-plugin-prettier": "^5.0.0" + }, + "engines" : { + "npm" : "^9.8.1", + "node" : "^18.16.0" } } diff --git a/src/_versions.ts b/src/_versions.ts index d8757cf..613422f 100644 --- a/src/_versions.ts +++ b/src/_versions.ts @@ -11,8 +11,8 @@ export interface TsAppVersion { export const versions: TsAppVersion = { version: '0.1.0', name: 'louis-finesse', - versionDate: '2023-10-23T15:10:05.957Z', - gitCommitHash: '23ecae9', - versionLong: '0.1.0-23ecae9', + versionDate: '2023-07-27T19:01:19.184Z', + gitCommitHash: '4eed505', + versionLong: '0.1.0-4eed505', }; export default versions; From afbc438d2ed154683a83688e531f0e3e4f153b02 Mon Sep 17 00:00:00 2001 From: CFIALeronB Date: Thu, 26 Oct 2023 14:15:18 -0400 Subject: [PATCH 5/8] Adding "engines" field to package-lock.json --- package-lock.json | 6 +++++- package.json | 6 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 668c07d..eda0a52 100644 --- a/package-lock.json +++ b/package-lock.json @@ -5,7 +5,7 @@ "requires": true, "packages": { "": { - "name": "finesse", + "name": "finesse-frontend", "version": "0.1.0", "dependencies": { "@saithodev/ts-appversion": "^2.2.0", @@ -30,6 +30,10 @@ "eslint-config-prettier": "^8.9.0", "eslint-config-standard-with-typescript": "^37.0.0", "eslint-plugin-prettier": "^5.0.0" + }, + "engines": { + "node": "^18.16.0", + "npm": "^9.8.1" } }, "node_modules/@aashutoshrathi/word-wrap": { diff --git a/package.json b/package.json index 530b559..58af047 100644 --- a/package.json +++ b/package.json @@ -58,8 +58,8 @@ "eslint-config-standard-with-typescript": "^37.0.0", "eslint-plugin-prettier": "^5.0.0" }, - "engines" : { - "npm" : "^9.8.1", - "node" : "^18.16.0" + "engines": { + "npm": "^9.8.1", + "node": "^18.16.0" } } From afbc99fcca7c9a924750fa9498e12de2e95ce5c4 Mon Sep 17 00:00:00 2001 From: CFIALeronB Date: Thu, 26 Oct 2023 14:35:09 -0400 Subject: [PATCH 6/8] Update postCreateCommand in devcontainer.json This commit updates the `postCreateCommand` in the `devcontainer.json` file to enhance the development environment setup process. Previously, the command was only updating npm to version 9.8.1. Now, it not only updates npm but also verifies the installed version using `npx npm -v` and runs `npx npm install` to ensure that all necessary dependencies are installed with the correct npm version. This change aims to provide a more robust and reliable setup for developers, reducing potential issues related to npm version mismatches and ensuring that all required packages are installed correctly. The use of `npx` ensures that we are using the correct version of npm for subsequent commands, providing an additional layer of verification to our setup process. --- .devcontainer/devcontainer.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 662ff8e..21f5810 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -4,8 +4,9 @@ "name": "Finesse Frontend Node.js project", // Use 'postCreateCommand' to run commands after the container is created. "image": "mcr.microsoft.com/devcontainers/javascript-node:0-18", - "postCreateCommand": "npm install -g npm@9.8.1 --force", + "postCreateCommand": "npm install -g npm@9.8.1 --force && npx npm -v && npx npm install", + // Configure tool-specific properties. // "customizations": {}, From 4aa59aec7446fdc60c0180c93a38afce8cf1e377 Mon Sep 17 00:00:00 2001 From: Leron Bergelson <133677161+CFIALeronB@users.noreply.github.com> Date: Tue, 31 Oct 2023 08:39:07 -0400 Subject: [PATCH 7/8] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d2dfd68..caa440c 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ Finesse is a project designed to provide users with the ability to search for ag ## Video Demonstration -[Finesse Demo Video](https://youtu.be/10hBAW4eXjc?si=lTCt9FiLwuW3GAXZ) +[Finesse Demo Video](https://www.youtube.com/watch?v=Bw6_azllnDw&t=9s) ## Usage From c1a3220edcb051d65f9ebfce7f6121a9ad0767fa Mon Sep 17 00:00:00 2001 From: Leron Bergelson <133677161+CFIALeronB@users.noreply.github.com> Date: Tue, 31 Oct 2023 16:08:19 -0400 Subject: [PATCH 8/8] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index caa440c..275ab7a 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ Finesse is a project designed to provide users with the ability to search for ag ## Video Demonstration -[Finesse Demo Video](https://www.youtube.com/watch?v=Bw6_azllnDw&t=9s) +[Finesse Demo Video](https://youtu.be/Bw6_azllnDw?si=-eO0BZQmi_iHXNr1) ## Usage