Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate consistent TS version across finesse-frontend #65

Open
vivalareda opened this issue Nov 27, 2023 · 2 comments · May be fixed by ai-cfia/finesse-frontend#58
Open

Validate consistent TS version across finesse-frontend #65

vivalareda opened this issue Nov 27, 2023 · 2 comments · May be fixed by ai-cfia/finesse-frontend#58
Assignees

Comments

@vivalareda
Copy link
Contributor

vivalareda commented Nov 27, 2023

          open an issue to automate validation that versions is provided consistently in our typescript projects and that the version is incremented between PR.

Originally posted by @rngadam in ai-cfia/finesse-frontend#45 (comment)

A mistake happened where the TS version was decreased so we want a check to make sure that we have consistency across the whole of finesse-frontend

vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 11, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 11, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 11, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 11, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 12, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 12, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 12, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 12, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 12, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 12, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 12, 2023
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 12, 2023
issue #47: add workflow and script
vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 12, 2023
@rngadam
Copy link
Contributor

rngadam commented Dec 13, 2023

The spec should be:

  • ensure that package.json version is incremented in a PR (higher version than main branch version)
  • that _versions.ts version matches this new version in package.json

vivalareda referenced this issue in ai-cfia/finesse-frontend Dec 19, 2023
@ThomasCardin ThomasCardin transferred this issue from ai-cfia/finesse-frontend Jan 8, 2024
@k-allagbe k-allagbe removed the status in Finesse Jan 24, 2024
@SonOfLope SonOfLope self-assigned this Jan 29, 2024
@SonOfLope
Copy link
Contributor

@rngadam @ThomasCardin I want to pick up this issue. Are the specs still valid ? Do we want this to be placed in the reusable workflow repo or should it stay here (that way it could be used for future projects)? I will branch from master instead of picking this branch but just want to be sure it is still needed.

Also, I suggest to do the validation directly in the workflow script instead of using a separate JavaScript file to reduce the number of files and points of failure.

TLDR :

  • Should I move the validation workflow to github-workflows repo ?
  • Can I implement the solution directly in the workflow file without using a js file ?

@ThomasCardin ThomasCardin moved this from Todo to In Progress in DevSecOps Apr 2, 2024
@ThomasCardin ThomasCardin moved this from In Progress to Todo in DevSecOps Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants