Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pollution from .mlc_config.json #95

Open
2 of 3 tasks
rngadam opened this issue Feb 7, 2024 · 3 comments
Open
2 of 3 tasks

Pollution from .mlc_config.json #95

rngadam opened this issue Feb 7, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@rngadam
Copy link
Contributor

rngadam commented Feb 7, 2024

  1. .mlc_config is getting added to the root of every repo - a file that is used to configure the github
    https://github.com/search?q=org%3Aai-cfia%20.mlc_config&type=code

config-file: '${{ inputs.config-file-path }}'

  1. this was created to fix links to LinkedIn where it is returning a non-standard 999 HTTP code for links accessed without a proper account

https://excellentwebcheck.com/blogs/what-is-http-999-request-denied-response-code

  1. this really should be a parameter to the github-workflows with default only expecting 200 (we generally shouldn't be pointing to pages that are 403
  • modify workflow-markdown-check.yml to take list of acceptable status code and reasonable default
  • remove .mlc_config from repo where it was inserted
  • fix the documentation to not require that file anymore
@rngadam rngadam added this to DevSecOps Feb 7, 2024
@ThomasCardin ThomasCardin self-assigned this Feb 14, 2024
@ThomasCardin ThomasCardin moved this to Todo in DevSecOps Feb 14, 2024
@ThomasCardin ThomasCardin added the good first issue Good for newcomers label Feb 23, 2024
@ThomasCardin ThomasCardin removed their assignment Feb 23, 2024
@ibrahim-kabir
Copy link

@SonOfLope I will remove my assignment to this issue, currently not available to work on a devops issue

@SonOfLope
Copy link
Contributor

SonOfLope commented Apr 5, 2024

I update the workflow due to a different issue where we notice the pipeline wasnt working properly. The updated workflow (once merged) will allow to provide the config file optionally. A default config file is provided in the github-workflow repo so we can now remove .mlc_config.json if needed. These changes resolve all the checks except

this really should be a parameter to the github-workflows with default only expecting 200 (we generally shouldn't be pointing to pages that are 403

I don't know about this. The workflow gives false positive sometimes about 403. Here is an example :
https://github.com/ai-cfia/github-workflows/actions/runs/8573751804/job/23499098138?pr=114
Doing a curl or manually visiting the website gives a 200 response but the workflow resolves into a 403.

@rngadam
Copy link
Contributor Author

rngadam commented Apr 5, 2024

Doing a curl or manually visiting the website gives a 200 response but the workflow resolves into a 403.

hmm, interesting. weird that it only denies checks from markdown. Then I guess we need to keep accepting 403 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

6 participants