Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I would like to be able to see latest changes from Nachet on the deployed instance #114

Closed
4 tasks done
SonOfLope opened this issue Mar 25, 2024 · 4 comments · Fixed by #117 or #164
Closed
4 tasks done
Assignees
Labels
good first issue Good for newcomers

Comments

@SonOfLope
Copy link
Contributor

SonOfLope commented Mar 25, 2024

The deployment is currently pointing to an old branch. I would like it to point to the main like Finesse does.

Issue Description

Currently, the main branch of Nachet is not up to date with the latest deployment. The current branch 51-implementing-2-models is pending review to able to be merged into main.

The actual issue with the deploy version is that it is not able to classify images. The return error 413 413 Request Entity Too Large could be either an ingress error or a backend error.

This error started on Friday and was discovered by Taran around 4 pm.

Change between the moment the deployment work and the problem was reported.

We had discussion about increasing the content length for uploads 2 weeks ago.

Test for investigation

  • Validate that the image source size is the same as the image size that was received by the backend.
    • Validate that the size is the same (Monday Morning).
  • Consult the log in ArgoCD while trying to classify an image.
    • Log doesn't update on both Nachet Container (Monday Morning)
  • Validate that ingress value is the good one
  • Update nachet main branch with latest change
@SonOfLope SonOfLope self-assigned this Mar 25, 2024
@SonOfLope SonOfLope removed their assignment Mar 25, 2024
@SonOfLope SonOfLope moved this to Todo in DevSecOps Mar 25, 2024
ThomasCardin added a commit that referenced this issue Mar 25, 2024
@MaxenceGui
Copy link

Report Issue

The default value for client_max_body_size in the ingex server is 1 MB and corresponds to the size of the image I was trying to classify. When testing different points mentioned in the issue I got the following result:

  • Image size in the backend was the same as the source image in the frontend
  • When trying to classify my test image (~ 0.8 MB) error 413 was returned but did not appear on any log in the backend.
  • When trying to classy test images lower than 1 MB (~ 0.1 MB and ~ 0.5 MB) the deployment was working and returned a result.

Conclusion

Even if the value is set up in the yaml file it seems the deployment doesn't follow that value of 200 MB and still block object bigger than 1 MB.

@MaxenceGui MaxenceGui linked a pull request Mar 25, 2024 that will close this issue
1 task
SonOfLope added a commit that referenced this issue Mar 25, 2024
@SonOfLope SonOfLope moved this from Todo to In Progress in DevSecOps Mar 26, 2024
MaxenceGui pushed a commit that referenced this issue Mar 26, 2024
issue #114: find why client_max_body_count is overriden
@github-project-automation github-project-automation bot moved this from In Progress to Done in DevSecOps Mar 26, 2024
@MaxenceGui
Copy link

Still need to change the deploy branch to main (when main is ready)

@MaxenceGui MaxenceGui reopened this Mar 26, 2024
@SonOfLope SonOfLope added the good first issue Good for newcomers label Mar 26, 2024
@SonOfLope SonOfLope moved this from Done to In Progress in DevSecOps Mar 26, 2024
@SonOfLope
Copy link
Contributor Author

What are we waiting for before doing this ?

@MaxenceGui
Copy link

What are we waiting for before doing this ?

Still waiting for this PR to be merged:

Waiting on @RussellJimmies approval

@MaxenceGui MaxenceGui linked a pull request Apr 10, 2024 that will close this issue
MaxenceGui pushed a commit that referenced this issue Apr 10, 2024
…to-be-able-to-see-latest-changes-from-nachet-on-the-deployed-instance

fixes #114: change image to nachet-backend main branch
@github-project-automation github-project-automation bot moved this from In Progress to Done in DevSecOps Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
2 participants