-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customisation for improving performance culture #325
Comments
The best way to do it right now is to use JSON output and generate text output by custom JS code. If you have a simple way to add a customization to Size Limit (for instance, by plugins), send PR. |
Ah ok, thanks. Makes sense. Is there any way to modify the Slow 3G settings? I've been looking for it for a while now, but looks like it's nowhere configured (which I don't believe). I could update the docs so others can find it as well. |
No, we did not plan to make it customizable. |
Will have a look the coming days to see if it's worth my time. Otherwise I'll close this issue. Thank you. |
@ai Sorry, why isn't it customizable? 99% of our clients are not on slow 3G so it'd be really helpful to have a more realistic metrics |
@zernie if nobody want to send PR, it means that feature is not very popular. |
I recently thought about this and maybe others agree on this. Why not add customisation to the messages shown in the CLI and CI.
For example. I updated line 156 of create-report.js to:
Can't find a way to modify the loading time. Currently it's set to Slow 3G (400kb/s & 2000ms latency). I would like to update it to the speed of our users.
This issue is not about solving this particular wish, it's about others as well. When possible to customise those messages, it will help to create awareness for the engineers.
Could elaborate on this and dive deeper into it, but I first want to see if people agree on this.
Possibly add it to the package.json. Just a rough draft:
The text was updated successfully, but these errors were encountered: