Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TF listener in BaseControllerInterface #169

Closed
bpapaspyros opened this issue Dec 4, 2024 · 2 comments · Fixed by #173
Closed

Add TF listener in BaseControllerInterface #169

bpapaspyros opened this issue Dec 4, 2024 · 2 comments · Fixed by #173
Assignees
@bpapaspyros

Comments

@bpapaspyros
Copy link
Member

Similarly to our design in ComponentInterface, we might imagine that some controllers may want to listen to TFs (i.e., to lookup frames, etc), or even broadcast them (reserved for a follow up issue/discussion).

As such, it's worth copying/adapting some of the functions from ComponentInterface to our BaseControllerInterface. We would then expose the same design, that is, optionally invoke add_tf_listener for controllers that want to use it.
@bpapaspyros bpapaspyros self-assigned this Dec 4, 2024
@bpapaspyros
Copy link
Member Author

fyi @eeberhard @domire8

@domire8
Copy link
Member

domire8 commented Dec 4, 2024

Absolutely, let's try to duplicate everything related to TF, also broadcaster.

@bpapaspyros bpapaspyros mentioned this issue Dec 5, 2024
Closed
@bpapaspyros bpapaspyros changed the title Add TF listener interface in BaseControllerInterface Add TF listener in BaseControllerInterface Dec 5, 2024
This was referenced Dec 5, 2024
Merged
Merged
Merged
@bpapaspyros bpapaspyros linked a pull request Dec 5, 2024 that will close this issue
feat: add TF listener and lookup TF helpers in BaseControllerInterface #173
Merged
1 task
bpapaspyros added a commit that referenced this issue Dec 5, 2024
@bpapaspyros
feat(controllers): add TF listener and lookup TF helpers in BaseContr…
ed20342 
…ollerInterface (#169)
bpapaspyros added a commit that referenced this issue Dec 5, 2024
@bpapaspyros
feat(controllers): add TF listener and lookup TF helpers in BaseContr…
428d01a 
…ollerInterface (#169)
bpapaspyros added a commit that referenced this issue Dec 5, 2024
@bpapaspyros
feat(controllers): add TF listener and lookup TF helpers in BaseContr…
222cbc8 
…ollerInterface (#169)
bpapaspyros added a commit that referenced this issue Dec 5, 2024
@bpapaspyros
feat(controllers): add TF listener and lookup TF helpers in BaseContr…
d106ba8 
…ollerInterface (#169)
domire8 added a commit that referenced this issue Dec 9, 2024
@domire8
Revert "feat(controllers): add TF listener and lookup TF helpers in B…
f9e91c3 
…aseControllerInterface (#169)"

This reverts commit d106ba8.
domire8 added a commit that referenced this issue Dec 9, 2024
@domire8
Revert "feat(controllers): add TF listener and lookup TF helpers in B…
d8343e1 
…aseControllerInterface (#169)"

This reverts commit d106ba8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpapaspyros bpapaspyros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add TF listener and lookup TF helpers in BaseControllerInterface aica-technology/modulo
2 participants
@bpapaspyros @domire8