Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Giganto's Publish API to Implement Request Type-Driven Processing #431

Open
msk opened this issue Jun 13, 2023 · 0 comments
Open

Comments

@msk
Copy link
Contributor

msk commented Jun 13, 2023

Currently, the Giganto Publish API defines multiple types of requests based on the NodeType of the client. This presents a problem where different clients, like Hog and REconverge, may need to send the same type of request. Currently, they can't do so because their NodeType might not permit it. This leads to inefficiency and lack of flexibility in request management.

I propose refactoring the publish API such that each request has its own request type, decoupling the ability to send specific requests from the client's NodeType. This would allow us to process each request according to its request type rather than the client's NodeType.

By doing this, NodeType becomes unnecessary for defining request handling, enabling each client to send any kind of request they find necessary. This promotes flexibility, efficiency, and ensures that all clients can utilize all the capabilities of the API.

Note:

One alternative might be to allow more NodeType definitions, but this would only make the system more complex and doesn't solve the underlying problem that the current setup is limiting clients' capabilities based on their node types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant