Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid false drops in query #25

Open
azizkayumov opened this issue Apr 23, 2023 · 0 comments
Open

Avoid false drops in query #25

azizkayumov opened this issue Apr 23, 2023 · 0 comments

Comments

@azizkayumov
Copy link
Collaborator

False drops of points in query may happen in random tests because of floating point round off errors. From the original SRTree source code (HnSRTreeNodeObject.cc):

		/*
		* NOTE:
		*
		*    Dec.13,2000 Norio KATAYAMA
		*
		*    Here ``getUpperBoundMaxDistance()'' is used for spheres
		*    in order to prevent false drops caused by round-off
		*    errors. As for rectangles, it is not necessary to use
		*    ``getUpperBoundMaxDistance()'' because the distance
		*    obtained by ``getMaxDistance()'' is guaranteed to be
		*    equal to or greater than the distance to the farthest
		*    point.
		*
		* Additional Note:
		*
		*    The above comment is satisfied only when the distance to
		*    a point is always measured by ``getDistance()'' and when
		*    bounding rectangles have the same precision with points.
		*    It is better to use ``getUpperBoundMaxDistance()'' instead
		*    of ``getMaxDistance()''.
		*/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant