Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll to top is confusing on long pages #18

Open
timabell opened this issue Jul 30, 2015 · 2 comments
Open

scroll to top is confusing on long pages #18

timabell opened this issue Jul 30, 2015 · 2 comments

Comments

@timabell
Copy link
Contributor

Hiya,

We now have the workaround for the unwanted scrolling down to the tab (pr #11), however I think we've created a different problem as a result.

The scroll to top is happening even when you already are on the page and just switching tabs. I don't think it should scroll at all when you already have the page open (easier said than done I know).

To see what I mean:

  • up the back-to-top test page
  • make your browser small enough that the filler text at the top pushes the tabs off the bottom of the window
  • scroll down to the tabs
  • click another tab
  • notice that the page is scrolled to the top and you can no longer see what you clicked on

this is in firefox.

@timabell
Copy link
Contributor Author

perhaps @jabbtech could pile in on this one?

@curtisweeks
Copy link

Hey @timabell!

Having the scroll to top always happen can be useful in instances where there is a desire to switch tabs while at the same time keeping a sites primary navigation at the top of a page in view. It wouldn't be too difficult to expand the backToTop option though, we could address the issue you described by passing the desired behavior like:

backToTop: always | onload | none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants