Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin PostgreSQL version #355

Closed
danielhollas opened this issue Feb 1, 2023 · 4 comments · Fixed by #356
Closed

Pin PostgreSQL version #355

danielhollas opened this issue Feb 1, 2023 · 4 comments · Fixed by #356
Assignees
Labels
dependencies Pull requests that update a dependency file question

Comments

@danielhollas
Copy link
Contributor

I've just hit an issue in one of my full-stack based container, which cannot start since it was created with PSQL=14, but somewhere along the way we updated to PSQL==15.

I've looked around and we don't seem to be in control of the PSQL version in our docker stacks. PSQL is installed as part of the aiida-core.services conda package. However, looking the the conda recipe on conda-forge, the psql version is not pinned, only a lower bound is given. @sphuber do I understand the situation correctly?

https://github.com/conda-forge/aiida-core-feedstock/blob/9bf266a74d8af2b0d866bb4d99f853fa3785c5c1/recipe/meta.yaml#L103

If that is the case, a major PSQL update can happen essentially any time we rebuild and publish the docker stack images here, which seems suboptimal, to put it mildly. Even when the automatic postgres migration is finished in #25, I'd say it is still highly desirable to be in control of the Postgres version, so that we do not inflict migrations on users randomly.

@unkcpz @yakutovicha if you agree, I'll cook up a PR with the change.

@danielhollas danielhollas self-assigned this Feb 1, 2023
@danielhollas danielhollas added question dependencies Pull requests that update a dependency file labels Feb 1, 2023
@unkcpz
Copy link
Member

unkcpz commented Feb 1, 2023

Thanks @danielhollas, I fully agree that we need to pin the PostgreSQL version for the image explicitly. Please go ahead with the PR.

@yakutovicha
Copy link
Member

I agree, with the proposition, thanks @danielhollas. The only question is whether to fix it here (in the docker stack) or in conda forge.

Probably, fixing the PGSQL version in the aiida-core services is not ideal, as it should represent the services with which aiida-core is compatible.

@danielhollas
Copy link
Contributor Author

Yeah, I've thought about it as well, and I also don't think fixing it in Conda is a good idea, since it would tie specific version of AiiDA to a specific version of PSQL, whereas normally you'd want to be able to upgrade AiiDA without upgrading PSQL.

@danielhollas
Copy link
Contributor Author

Thanks @yakutovicha. Btw as you can see, the project automation works and the issue has been automatically marked as Done when being closed by merging the PR. CC @unkcpz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants